Skip to content

Fix rendering of attribute constants #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kocsismate wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −1
Open

Fix rendering of attribute constants #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870c6be
Fix rendering of attribute constants
kocsismate Mar 11, 2026
b79ab5f
Add test
kocsismate Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpdotnet/phd/Package/Generic/XHTML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,7 @@ public function format_fieldsynopsis($open, $name, $attrs) {
}

public function format_fieldsynopsis_modifier_text($value, $tag) {
$this->cchunk["fieldsynopsis"]["modifier"] = trim($value);
if ($this->getRole() === "attribute") {
$attribute = trim(strtolower($value), "#[]\\");
$href = Format::getFilename("class.$attribute");
Expand All @@ -1435,7 +1436,6 @@ public function format_fieldsynopsis_modifier_text($value, $tag) {
}
return false;
}
$this->cchunk["fieldsynopsis"]["modifier"] = trim($value);
return $this->TEXT($value);
}

Expand Down
17 changes: 17 additions & 0 deletions tests/package/generic/attribute_formatting_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,21 @@ Content:
}</div>
</div>

<div class="section">
<p class="para">3. Constant of a class with attribute</p>
<div class="classsynopsis"><div class="classsynopsisinfo">

<span class="attribute">#[\UnknownAttribute]</span><br>
<span class="modifier">class</span> <strong class="classname">ClassName</strong>
{</div>
<div class="classsynopsisinfo classsynopsisinfo_comment">/* Constants */</div>
<div class="fieldsynopsis">
<span class="modifier">public</span>
<span class="modifier">const</span>
<span class="type">string</span>
<var class="fieldsynopsis_varname">CONSTANT_NAME</var>;</div>

}</div>
</div>

</div>
17 changes: 17 additions & 0 deletions tests/package/generic/data/attribute_formatting_003.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,21 @@
</classsynopsis>
</section>

<section>
<para>3. Constant of a class with attribute</para>
<classsynopsis class="class">
<ooclass>
<modifier role="attribute">#[\UnknownAttribute]</modifier>
<classname>ClassName</classname>
</ooclass>
<classsynopsisinfo role="comment">Constants</classsynopsisinfo>
<fieldsynopsis>
<modifier>public</modifier>
<modifier>const</modifier>
<type>string</type>
<varname>CONSTANT_NAME</varname>
</fieldsynopsis>
</classsynopsis>
</section>

</chapter>