ext/gmp: gmp_fact() reject values larger than unsigned long.#21794
Open
devnexen wants to merge 1 commit intophp:masterfrom
Open
ext/gmp: gmp_fact() reject values larger than unsigned long.#21794devnexen wants to merge 1 commit intophp:masterfrom
devnexen wants to merge 1 commit intophp:masterfrom
Conversation
LamentXU123
reviewed
Apr 18, 2026
| } | ||
|
|
||
| // TODO: Check that we don't an int that is larger than an unsigned long? | ||
| // Could use mpz_fits_slong_p() if we revert to using mpz_get_si() |
Contributor
There was a problem hiding this comment.
This comment shouldn't be deleted (?)
Member
Author
There was a problem hiding this comment.
The TODO is resolved by the new check right below — mpz_fits_ulong_p(gmpnum) is exactly what it was asking for. Keeping the comment would misleadingly suggest the
work is still pending. But wiating fairly Gina's opinion on it first :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.