Skip to content

sqlite3: Fix leak when trying to close db if blob stream is still open #22992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+25 −1
Open

sqlite3: Fix leak when trying to close db if blob stream is still open #22992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ext/sqlite3/sqlite3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2255,7 +2255,9 @@ static void php_sqlite3_object_free_storage(zend_object *object) /* {{{ */
}

if (intern->initialised && intern->db) {
sqlite3_close(intern->db);
/* Use sqlite3_close_v2() because the object may be destroyed while resources depending on the connection are still alive,
* e.g. a blob stream created by SQLite3::openBlob(). */
sqlite3_close_v2(intern->db);
intern->initialised = 0;
}

Expand Down
22 changes: 22 additions & 0 deletions ext/sqlite3/tests/sqlite3_close_blob_stream.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
--TEST--
Destroying the SQLite3 object while a blob stream is still open must not leak the connection
--EXTENSIONS--
sqlite3
--FILE--
<?php

$db = new SQLite3(':memory:');
$db->exec('CREATE TABLE test (data BLOB)');
$db->exec("INSERT INTO test (data) VALUES (x'34323432')");

$stream = $db->openBlob('test', 'data', 1);
var_dump($db->close());
unset($db);
var_dump(fread($stream, 4));
fclose($stream);

?>
--EXPECTF--
Warning: SQLite3::close(): Unable to close database: %s in %s on line %d
bool(false)
string(4) "4242"
Loading