Skip to content

Fix broken relative links on manual pages #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KentarouTakeda wants to merge 1 commit into from
+1 −1
Closed

Fix broken relative links on manual pages #1918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/header.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ if (!isset($config["languages"])) {
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">

<base href="https://www.php.net">
<base href="https://www.php.net/<?php echo $_SERVER['BASE_PAGE'] ?? '' ?>">

@sy-records sy-records Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I think the old way was better. Now, when I click on it during the preview test, it redirects to php.net.

Suggested change
<base href="https://www.php.net/<?php echo $_SERVER['BASE_PAGE'] ?? '' ?>">
<?php if (!empty($_SERVER["BASE_HREF"])): ?>
<base href="<?php echo $_SERVER["BASE_HREF"]; ?>">
<?php endif ?>

@KentarouTakeda KentarouTakeda Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! That's a side effect of pinning the host, and it's intentional: the suggested code derives the href from SERVER_NAME — that's how new.www.internal.php.net ended up in the <base> and broke asset loading (#1917). This PR restores only the path part, using the same pattern as the canonical link below.

@derickr derickr Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KentarouTakeda Not quite — I hadn't set the original host to be fed through to the CDN. The commit that I made yesterday can be reverted. I will now do that (and hence, I can close this PR too).


<title><?php echo $title ?></title>

Expand Down
Loading