Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/preview-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on:
types: [ labeled ]

jobs:
tests_visual:
name: "Visual Tests"
tests_e2e:
name: "E2E Tests"
runs-on: "ubuntu-latest"
if: "github.repository_owner == 'php' && contains(github.event.pull_request.labels.*.name, 'Status: Preview Allowed')"

Expand Down Expand Up @@ -77,8 +77,8 @@ jobs:
- name: "Install Playwright"
run: "npx playwright install"

- name: "Run visual tests"
run: "make tests_visual"
- name: "Run E2E tests"
run: "make tests_e2e"

- name: Upload playwright report
uses: actions/upload-artifact@v7
Expand Down
74 changes: 0 additions & 74 deletions .github/workflows/update-screenshots.yaml

This file was deleted.

9 changes: 2 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,9 @@ tests: vendor ## Runs unit and end-to-end tests with phpunit/phpunit
vendor/bin/phpunit --configuration=tests/phpunit.xml --testsuite=end-to-end;
tests/server stop

tests_visual:
tests_e2e:
tests/server start;
npx playwright test --workers=$(CORES)
tests/server stop

tests_update_snapshots:
tests/server start;
npx playwright test --update-snapshots
npx playwright test
tests/server stop

vendor: composer.json composer.lock
Expand Down
5 changes: 0 additions & 5 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ export default defineConfig({
timeout: 0,

projects: [
{
name: 'chromium',
use: {...devices['Desktop Chrome']},
testDir: './tests/Visual',
},
{
name: 'End-to-End Chromium',
use: {...devices['Desktop Chrome']},
Expand Down
Loading