Collect dependencies defined in @throws docblock tags#513
Draft
micheleorselli wants to merge 6 commits intomainfrom
Draft
Collect dependencies defined in @throws docblock tags#513micheleorselli wants to merge 6 commits intomainfrom
micheleorselli wants to merge 6 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
============================================
+ Coverage 97.85% 97.89% +0.03%
- Complexity 646 657 +11
============================================
Files 83 83
Lines 1864 1896 +32
============================================
+ Hits 1824 1856 +32
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Collaborator
|
fixes #514 |
Collaborator
|
to complete this we should fix the row number, that now is the first line of the comment instead of the line of the throws. |
fain182
pushed a commit
that referenced
this pull request
Feb 10, 2026
…correct line numbers - Merge PR #513 branch (collect_throws_types) into working branch - Resolve conflicts in FileVisitor.php (keep both handlePropertyHookNode and handleThrowsTags) - Fix @throws line number: previously used method start line, now computes the actual file line of each @throws tag using PHPStan's startLine attribute combined with the docblock's start line in the file - Modify Docblock::getThrowTagsTypes() to return [{type, line}] pairs instead of plain strings, exposing per-tag line info from PHPStan parser - Update tests to reflect that PHP core classes (e.g. \Exception) are filtered out by the existing isPhpCoreClass() check in ClassDescriptionBuilder Fixes #514 https://claude.ai/code/session_01H3NqdUfGArp9bzf1WiXMos
Add two integration tests to verify that dependencies defined in @throws docblock tags are properly collected: - test_it_collects_throws_tag_as_dependencies: Tests collection of relative and fully qualified exception names in @throws tags - test_it_collects_throws_tag_with_fully_qualified_names: Tests handling of different naming conventions (backslash-prefixed, relative to namespace) These tests validate that the @throws tag parsing feature works end-to-end and that exceptions are properly resolved to their fully qualified names. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
fain182
force-pushed
the
collect_throws_types
branch
from
fa33a58 to
abad339
Compare
- Exception and other PHP core classes are filtered by isPhpCoreClass, so they should not be expected as collected dependencies - Restore NotBlank and UuidFactoryInterface in DocblockTypesResolverTest which were incorrectly removed from expectations - Replace deprecated PHP_7_4 constant with PHP_8_0 Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The startLine attribute was incorrectly set to the method's start line. Now uses the docblock start line combined with the relative line of each @throws tag (from ParserConfig lines=true) to compute the correct absolute line in the file. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.