Include constant name in deprecation message when a description exists

[mglaman]

FetchingDeprecatedConstRule passes the deprecation description to sprintf() as the format string:

RuleErrorBuilder::message(sprintf(
    $constantReflection->getDeprecatedDescription() ?? 'Use of constant %s is deprecated.',
    $constantReflection->getName(),
))

The %s placeholder for the constant name only exists in the fallback message, so any constant documented with @deprecated text reports the description alone. Analyzing Drupal code that uses REQUIREMENT_ERROR produces:

in drupal:11.2.0 and is removed from drupal:12.0.0. Use \Drupal\Core\Extension\Requirement\RequirementSeverity::Error instead.

There is no way to tell which constant triggered it, which is a problem when a single line fetches several deprecated constants.

This formats the message the way the other deprecation checks do (RestrictedDeprecatedFunctionUsageExtension, RestrictedDeprecatedClassConstantUsageExtension) — name first, description on the next line:

Use of constant REQUIREMENT_ERROR is deprecated:
in drupal:11.2.0 and is removed from drupal:12.0.0. Use \Drupal\Core\Extension\Requirement\RequirementSeverity::Error instead.

Messages for constants without a description are unchanged. Added a test covering the described case.

🤖 Generated with Claude Code