Add support for newer Symfony versions in tests#483
Add support for newer Symfony versions in tests#483stof wants to merge 2 commits intophpstan:2.0.xfrom
Conversation
|
I started working on something similar here but it's challenging https://github.com/phpstan/phpstan-symfony/pull/447/changes |
|
This would be great ! Thanks for working on it |
|
@VincentLanglet @ondrejmirtes what is the way to handle those for the test failures themselves, I will handle them (tests relying on the messenger MessageSubscriberInterface must be skipped for versions where the interface does not exist anymore, and we should have alternative tests using the |
|
What about a conditional baseline, like it's done on PHPStan repository with php versions But I'm fine with a phpstan-ignore comment |
Symfony 5.4 is in security-only mode since years (and would already be EOL if its maintenance window had not been extended compared to the normal release schedule). Testing only Symfony 5.4 in CI does not reflect current usage of the extension.