Open
Conversation
The generate script gets added to the win32-dev directory so that the entire directory can be distributed and used by other parties. The activate script works just like the python virtualenv activate script but does not modify the prompt. I was undecided on this so I didn't do it. The activate script also export the WIN32_DEV_TOP environment variable which libpurple/win32/global.mak will use if set which means you can download a pre-build win32-dev directory, activate it, and build pidgin without touching a single Makefile. Fixes pidgin#3
EionRobb
approved these changes
May 29, 2025
EionRobb
left a comment
EionRobb
left a comment
There was a problem hiding this comment.
Ooh this is cool.
Would be amazing to turn into a github action later on down the track, too 💜
Member
Author
Well the idea was to create an artifact that actions can use, but I don't know enough about actions to turn it into one, at least not right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated script gets added to the win32-dev directory so that the entire directory can be distributed and used by other parties.
The activate script works just like the python virtualenv activate script but does not modify the prompt. I was undecided on this so I didn't do it.
The activate script also exports the
WIN32_DEV_TOPenvironment variable whichlibpurple/win32/global.makwill use if set which means you can download a pre-build win32-dev directory, activate it, and build pidgin without touching a single Makefile.Fixes #3