Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c81719c89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type="submit" | ||
| variant="default" | ||
| size="icon" | ||
| className="hidden md:flex" |
There was a problem hiding this comment.
This shared form now hard-codes className="hidden md:flex" on the submit button, which removes the only explicit submit affordance on mobile when HomeFetchForm uses this component. On touch devices, users can end up with no tappable way to trigger fetch unless they use the keyboard’s enter/go action, which is a regression from the previous home form behavior that always showed a button.
Useful? React with 👍 / 👎.
amadeus
force-pushed
the
beta-1.2
branch
3 times, most recently
from
482133a to
7597cd8
Compare
mdo
force-pushed
the
mdo/dark-mode-plus-form-view
branch
from
0c81719 to
abca428
Compare
|
Brought this back properly rebased, but I think we skip it—our pages load too fast and we get some weirdness. Unsure how we'd animate in the tree and diffs alongside this. Going to punt for now. |
1 participant
No description provided.