Skip to content

More Iteration & Polish#655

Merged
amadeus merged 8 commits intobeta-1.2from
amadeus/misc-polish
May 7, 2026
Merged

More Iteration & Polish#655
amadeus merged 8 commits intobeta-1.2from
amadeus/misc-polish

Conversation

@amadeus
Copy link
Copy Markdown
Member

@amadeus amadeus commented May 7, 2026

This branch address two items:

  1. A system to do linkable selections to a diff (stored in the hash, works great on initialize)
  2. Fix collapsing UI when the file has no content (disable the button, show permanently in a collapsed state)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffshub Ready Ready Preview May 7, 2026 9:52pm
pierre-docs-trees Ready Ready Preview May 7, 2026 9:52pm
pierrejs-diff-demo Ready Ready Preview May 7, 2026 9:52pm
pierrejs-docs Ready Ready Preview May 7, 2026 9:52pm

Request Review

@amadeus
Copy link
Copy Markdown
Member Author

amadeus commented May 7, 2026

@codex

@amadeus amadeus marked this pull request as ready for review May 7, 2026 21:35
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d984aeb270

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/docs/app/(diffshub)/(view)/_components/CodeViewWrapper.tsx
@amadeus
Copy link
Copy Markdown
Member Author

amadeus commented May 7, 2026

@codex

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@amadeus amadeus merged commit 9c6d9ad into beta-1.2 May 7, 2026
12 checks passed
@amadeus amadeus deleted the amadeus/misc-polish branch May 7, 2026 22:00
amadeus added a commit that referenced this pull request May 8, 2026
* Phase 1: Add support for scrollTo on selection ranges

* Phase 2: tests!

* Phase 3: getting hashing hooked up to selection

* First pass at hash linking to lines/ranges

* cleaner id syntax now

* Prettify the url encoding a bit

* Fix collapse/expansion if no content (disable it and show collapsed)

* PR review fix
amadeus added a commit that referenced this pull request May 8, 2026
* Phase 1: Add support for scrollTo on selection ranges

* Phase 2: tests!

* Phase 3: getting hashing hooked up to selection

* First pass at hash linking to lines/ranges

* cleaner id syntax now

* Prettify the url encoding a bit

* Fix collapse/expansion if no content (disable it and show collapsed)

* PR review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant