You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Using floating numbers for Time Differences - #1191
Python's timedelta class can accept floating point numbers as fields, so why restrict ourselves to integers?
This commit was spurred by attempting khal new <datetime> 2.5h <summary> and seeing it failed.
There was a button on github that said "Update Branch" and it made the "Merge branch 'master' into master" commit. Don't know what was up with that.
I assume the master branch of your fork of khal, to which you commited your changes suggested in this PR, had been branched off an 'outdated' version of this main repositories master branch (or rather, someone else made changes here after your initial branching off). To resolve any potential merge conflicts resulting from that, this repo's master branch was merged on top of yours, applying those 'missing' (but unrelated) changes to 'your' master branch and creating a merge commit to either resolve some actual conflict or preserve the commit relation in the git log.
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this, but changes make sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's
timedeltaclass can accept floating point numbers as fields, so why restrict ourselves to integers?This commit was spurred by attempting
khal new <datetime> 2.5h <summary>and seeing it failed.