Skip to content

feat(swift-ios): show workspace images inline - #6133

Draft
saphid wants to merge 6 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-inline-workspace-images-current
Draft

feat(swift-ios): show workspace images inline#6133
saphid wants to merge 6 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:saphid/swiftui-inline-workspace-images-current

Conversation

@saphid

@saphid saphid commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What Changed

This PR remains image-only. Workspace videos continue to render as fallback text, and there are no server, wire, web, desktop, or React Native changes.

Dependency

Chain order: #5803#6132#6133.

The exact published parent of this PR is #6132 head b19aab5339f851323b706ad7360fb810d35fd034. Review only the final image commit until both dependencies land.

Failure repair

The prior #6133 head failed five HomeThreadMetadataTests provider-catalog assertions inherited from its stale pre-Theo chain. #6132 was independently refreshed against Theo, then repaired for current Macroscope findings at b19aab533; this PR is rebuilt directly on that exact parent. The approved inline-workspace-image behavior was not changed to repair the original unrelated failures.

Verification

Current head: 83272ae26ec674dff4da64d573d81aec41708173
Theo target: f98cab553546558e28d6e22f3dbe9807ecc3325f

  • affected native tests after review fixes: 48 passed, 0 failed, 0 skipped on a fresh task-owned iPhone 17 Pro / iOS 26.5 Simulator
  • full native gate after review fixes: 343 passed, 0 failed, 1 skipped
  • generated Swift wire fixtures: matched
  • exact-head Debug app: built, installed, and launched successfully in Simulator
  • exact-head interaction: transcript exposed Open image Generated image; Generated video remained text; tapping the image opened workspace-file-preview with Files, Done, File info, and Share image
  • git diff --check: passed
  • personal standards/spec review: no remaining actionable findings
  • Macroscope findings addressed at their owning layers: environment-safe provider fallback and nested file links in feat(swift-ios): add file preview navigation and info #6132; resolved nested-image tap URL in feat(swift-ios): show workspace images inline #6133
  • direct independent reviewer: Claude Code 2.1.224 invoked claude-opus-5 at high effort, but exited 1 with the Anthropic session limit before returning a verdict; no Opus findings or approval are claimed

UI evidence

Exact-head Simulator video — Tailnet-only, H.264, 247,743 bytes, SHA-256 5d36e053e12f4559394f1095b314e1d02adb78c43a1a1c5d76506fe1a7ef20f8; full and byte-range downloads verified.

Delivery: chain
Validated against Theo commit: f98cab5
Depends on: #5803, #6132
Merge order: #5803#6132#6133
Validation status: Current head 83272ae is mergeable and every actionable current-head CI/review check is green, with no unresolved review threads. Revalidate after #5803 lands, then again after #6132 lands. The unrelated Vercel authorization failure is a maintainer-side gate.

Built with GPT-5.6 Sol in the Codex harness.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14917b0d-89aa-453a-be73-249573e3de53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 11, 2026
Comment thread apps/swift-ios/Features/Chat/MarkdownDocument.swift Outdated
Comment thread apps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
Comment thread apps/swift-ios/Features/Files/FeatureFilesView.swift
Comment thread apps/swift-ios/Features/Chat/MarkdownDocument.swift
Comment thread apps/swift-ios/Features/Files/FeatureWorkspacePathResolver.swift
Comment thread apps/swift-ios/Features/Chat/ThreadDetailView.swift Outdated
Comment thread apps/swift-ios/Features/Chat/MarkdownDocument.swift
@saphid
saphid force-pushed the saphid/swiftui-inline-workspace-images-current branch from 7612517 to dda7b23 Compare August 12, 2026 13:27
Comment thread apps/swift-ios/Features/Workspace/DailyUXModels.swift
Comment thread apps/swift-ios/Features/Chat/MarkdownWorkspaceImageView.swift Outdated
@saphid
saphid force-pushed the saphid/swiftui-inline-workspace-images-current branch from dda7b23 to 893cd19 Compare August 12, 2026 13:43
@saphid
saphid force-pushed the saphid/swiftui-inline-workspace-images-current branch from 893cd19 to 83272ae Compare August 12, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant