feat(swift-ios): show workspace images inline - #6133
Draft
saphid wants to merge 6 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…t' into saphid/swiftui-file-preview-navigation
saphid
force-pushed
the
saphid/swiftui-inline-workspace-images-current
branch
from
August 12, 2026 13:27
7612517 to
dda7b23
Compare
saphid
force-pushed
the
saphid/swiftui-inline-workspace-images-current
branch
from
August 12, 2026 13:43
dda7b23 to
893cd19
Compare
saphid
force-pushed
the
saphid/swiftui-inline-workspace-images-current
branch
from
August 12, 2026 13:59
893cd19 to
83272ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR remains image-only. Workspace videos continue to render as fallback text, and there are no server, wire, web, desktop, or React Native changes.
Dependency
Chain order: #5803 → #6132 → #6133.
The exact published parent of this PR is #6132 head
b19aab5339f851323b706ad7360fb810d35fd034. Review only the final image commit until both dependencies land.Failure repair
The prior #6133 head failed five
HomeThreadMetadataTestsprovider-catalog assertions inherited from its stale pre-Theo chain. #6132 was independently refreshed against Theo, then repaired for current Macroscope findings atb19aab533; this PR is rebuilt directly on that exact parent. The approved inline-workspace-image behavior was not changed to repair the original unrelated failures.Verification
Current head:
83272ae26ec674dff4da64d573d81aec41708173Theo target:
f98cab553546558e28d6e22f3dbe9807ecc3325fOpen image Generated image;Generated videoremained text; tapping the image openedworkspace-file-previewwith Files, Done, File info, and Share imagegit diff --check: passedclaude-opus-5at high effort, but exited 1 with the Anthropic session limit before returning a verdict; no Opus findings or approval are claimedUI evidence
Exact-head Simulator video — Tailnet-only, H.264, 247,743 bytes, SHA-256
5d36e053e12f4559394f1095b314e1d02adb78c43a1a1c5d76506fe1a7ef20f8; full and byte-range downloads verified.Delivery: chain
Validated against Theo commit: f98cab5
Depends on: #5803, #6132
Merge order: #5803 → #6132 → #6133
Validation status: Current head 83272ae is mergeable and every actionable current-head CI/review check is green, with no unresolved review threads. Revalidate after #5803 lands, then again after #6132 lands. The unrelated Vercel authorization failure is a maintainer-side gate.
Built with GPT-5.6 Sol in the Codex harness.