feat(swift-ios): start a new thread on the same branch - #6136
Draft
saphid wants to merge 15 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Dependency
Stacked on #6135, #6134, and #6117. Review commit
91798e9abfor this feature until those PRs land.Verification
ThreadNewTaskSeedTestsand the affected new-task/sidebar suites passed on iOS Simulator after conflict resolutiongit diff --check: passedUI
The row menu opens a prefilled new-task sheet targeting the same branch without mutating the source thread.
Note
Add 'New thread on same branch' action and settle-undo toast to iOS thread sidebar
NewThreadViewwith the source thread's branch and worktree, surfacing specific errors when the branch is unavailable.setSettled,setSnoozed, andsetPinnedonFeatureRootModelnow returnBoolindicating mutation success, used by the undo flow to gate toast presentation.Macroscope summarized 91798e9.