fix(swift-ios): remove composer line cap - #6147
Draft
saphid wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the numeric seven-line composer cap while keeping very tall drafts bounded by the available viewport.
Scope
One extracted feature commit touching only FeatureComposerView and FeatureComposerPowerTests.
Verification
Dependencies and gate
Note
Remove 7-line cap from iOS chat composer text input
.lineLimit(1...7)on the composerTextFieldwith a newFeatureComposerGrowingTextInputview modifier that applies an unbounded.lineLimit(1...)and raises.layoutPriority(1).@MainActortests in FeatureComposerPowerTests.swift verifying growth beyond 3 lines and respect for viewport height limits.Macroscope summarized c687717.