Sort VPCConfig fields in live manifest and enhance tests#6535
Open
rishichirchi wants to merge 1 commit intopipe-cd:masterfrom
Open
Sort VPCConfig fields in live manifest and enhance tests#6535rishichirchi wants to merge 1 commit intopipe-cd:masterfrom
rishichirchi wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: Rishi Chirchi <rishiraj.chirchi@gmail.com>
1bd4262 to
3f0b18d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix false drift detection for Lambda applications with VPC configuration.
In PR #5254, the same subnet ordering problem was fixed for ECS drift detection by sorting subnets on both the live state and head spec sides.
However, this fix was never applied to Lambda drift detection.
The
ignoreAndSortParametersfunction only sortedheadSpec.VPCConfig.SubnetIDs(Git side), and the comment claimed "Lambda sorts them in liveSpec" but the AWS Lambda API does not guarantee any specific ordering of SubnetIDs or SecurityGroupIDs. This caused false drift detection when the ordering returned by AWS didn't match the user's manifest.This fix:
sortLiveManifestParameters()to sortSubnetIDsandSecurityGroupIDson the live (AWS) side before comparison, consistent with the ECS fix in Sort subnet in live manifest of ECS Drift Detection #5254SecurityGroupIDson the head (Git) side, which was previously not sorted at allsortLiveManifestParametersfunction and forSecurityGroupIDssortingWhich issue(s) this PR fixes:
Fixes #6529
Does this PR introduce a user-facing change?: