Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ Methods:

- `start()`
- `stop()`
- `optimize(buffer, width, quality, allowSVG?)` (auto-starts on first use)
- `fetchAndOptimize(url, width, quality, allowSVG?)` (auto-starts on first use)
- `optimize(buffer, width, quality, allowSVG?, enqueueOptions?)` (auto-starts on first use)
- `fetchAndOptimize(url, width, quality, allowSVG?, enqueueOptions?)` (auto-starts on first use)

`enqueueOptions` is forwarded to `@platformatic/job-queue` `enqueueAndWait()` (for example: `timeout`, `maxAttempts`, `resultTTL`).

### `createQueue(options?)`

Expand Down
56 changes: 37 additions & 19 deletions src/queue.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Queue as JobQueue, MemoryStorage } from '@platformatic/job-queue'
import type { EnqueueAndWaitOptions, Queue as JobQueue, MemoryStorage } from '@platformatic/job-queue'
import { InternalServerError } from 'http-errors-enhanced'
import { randomUUID } from 'node:crypto'
import { fetchAndOptimize, optimize } from './operations.ts'
Expand Down Expand Up @@ -86,26 +86,44 @@ export class Queue {
this.#started = false
}

async optimize (buffer: Buffer, width: number, quality: number, allowSVG = false): Promise<Buffer> {
const result = await this.#enqueueAndWait({
type: 'optimize',
buffer: buffer.toString('base64'),
width,
quality,
allowSVG
})
async optimize (
buffer: Buffer,
width: number,
quality: number,
allowSVG = false,
options?: EnqueueAndWaitOptions
): Promise<Buffer> {
const result = await this.#enqueueAndWait(
{
type: 'optimize',
buffer: buffer.toString('base64'),
width,
quality,
allowSVG
},
options
)

return Buffer.from(result.buffer, 'base64')
}

async fetchAndOptimize (url: string, width: number, quality: number, allowSVG = false): Promise<Image<Buffer>> {
const result = await this.#enqueueAndWait({
type: 'fetchAndOptimize',
url,
width,
quality,
allowSVG
})
async fetchAndOptimize (
url: string,
width: number,
quality: number,
allowSVG = false,
options?: EnqueueAndWaitOptions
): Promise<Image<Buffer>> {
const result = await this.#enqueueAndWait(
{
type: 'fetchAndOptimize',
url,
width,
quality,
allowSVG
},
options
)

return {
buffer: Buffer.from(result.buffer, 'base64'),
Expand All @@ -114,12 +132,12 @@ export class Queue {
}
}

async #enqueueAndWait (payload: QueuePayload): Promise<Image<string>> {
async #enqueueAndWait (payload: QueuePayload, options?: EnqueueAndWaitOptions): Promise<Image<string>> {
if (!this.#queue || !this.#started) {
await this.start()
}

return this.#queue!.enqueueAndWait(randomUUID(), payload)
return this.#queue!.enqueueAndWait(randomUUID(), payload, options)
}

async #execute ({ payload }: Job): Promise<Image<string>> {
Expand Down
52 changes: 52 additions & 0 deletions test/queue.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,39 @@ class BrokenJobQueueModuleQueue extends Queue {
}
}

class EnqueueOptionsSpyJobQueue {
static calls: Array<{ payload: any; options: any }> = []

execute (): void {}

async start (): Promise<void> {}

async stop (): Promise<void> {}

async enqueueAndWait (_id: string, payload: any, options?: any): Promise<any> {
EnqueueOptionsSpyJobQueue.calls.push({ payload, options })

if (payload.type === 'optimize') {
return { buffer: payload.buffer }
}

return {
buffer: Buffer.from('queued-image').toString('base64'),
contentType: 'image/webp',
cacheControl: 'public, max-age=10'
}
}
}

class EnqueueOptionsQueue extends Queue {
protected static async loadJobQueueModule (): Promise<any> {
return {
Queue: EnqueueOptionsSpyJobQueue,
MemoryStorage: class {}
}
}
}

const fixtures = join(import.meta.dirname, 'fixtures', 'before')
const width = 120
const quality = 60
Expand Down Expand Up @@ -130,6 +163,25 @@ test('Queue optimizes images through queue jobs', async () => {
await optimizer.stop()
})

test('Queue optimize and fetchAndOptimize forward enqueue options', async () => {
EnqueueOptionsSpyJobQueue.calls = []

const optimizer = new EnqueueOptionsQueue()
await optimizer.start()

const optimizeOptions = { timeout: 1200, maxAttempts: 4, resultTTL: 30_000 }
await optimizer.optimize(Buffer.from('source'), width, quality, false, optimizeOptions)

const fetchOptions = { timeout: 2400, maxAttempts: 2, resultTTL: 60_000 }
await optimizer.fetchAndOptimize('https://queue-images.example/source.webp', width, quality, false, fetchOptions)

equal(EnqueueOptionsSpyJobQueue.calls.length, 2)
deepEqual(EnqueueOptionsSpyJobQueue.calls[0].options, optimizeOptions)
deepEqual(EnqueueOptionsSpyJobQueue.calls[1].options, fetchOptions)

await optimizer.stop()
})

test('Queue fetchAndOptimize returns buffer and response metadata', async () => {
const optimizer = new Queue()
await optimizer.start()
Expand Down