Skip to content

[Bug] Component generation needs double quote extract_path #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonymilne wants to merge 5 commits into
base: dev
Choose a base branch
from
+1 −8
Open

[Bug] Component generation needs double quote extract_path #3621

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
138297d
Double quote `extract_path`
antonymilne Feb 23, 2026
2f90b0e
Fix cross-platform subprocess call for Windows compatibility
antonymilne Feb 24, 2026
abe76c7
Merge branch 'dev' into dev
T4rk1n Mar 9, 2026
7c2329a
Merge branch 'dev' into dev
camdecoster Mar 26, 2026
3944e44
Merge branch 'dev' into dev
T4rk1n Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions dash/development/component_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import json
import sys
import subprocess
import shlex
import os
import argparse
import shutil
Expand Down Expand Up @@ -56,8 +55,6 @@

project_shortname = project_shortname.replace("-", "_").rstrip("/\\")

is_windows = sys.platform == "win32"

# Get path to extract-meta.js using importlib.resources
try:
# Python 3.9+
Expand All @@ -83,18 +80,14 @@
# Ensure local node modules is used when the script is packaged.
env["MODULES_PATH"] = os.path.abspath("./node_modules")

cmd = shlex.split(
f'node {extract_path} "{ignore}" "{reserved_patterns}" {components_source}',
posix=not is_windows,
)
cmd = ["node", extract_path, ignore, reserved_patterns, components_source]

proc = subprocess.Popen( # pylint: disable=consider-using-with
cmd,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
shell=is_windows,
env=env,
)

Check failure on line 90 in dash/development/component_generator.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

LLMs running this code with faulty CLI arguments can escape from shell sandboxes. Refactor this code to validate untrusted data before passing them to OS commands. 


See more on https://sonarcloud.io/project/issues?id=plotly_dash&issues=AaAbG49isbbbzkBBNXlR&open=AaAbG49isbbbzkBBNXlR&pullRequest=3621
out, err = proc.communicate()
status = proc.poll()

Expand Down
Loading