Skip to content

Feature: Integrate dash uploader#3850

Closed
rakrsh wants to merge 7 commits into
plotly:devfrom
rakrsh:integrate_dash_uploader
Closed

Feature: Integrate dash uploader#3850
rakrsh wants to merge 7 commits into
plotly:devfrom
rakrsh:integrate_dash_uploader

Conversation

@rakrsh

@rakrsh rakrsh commented Jun 28, 2026

Copy link
Copy Markdown

Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

rakrsh and others added 7 commits June 28, 2026 11:58
…t mode compatibility

- Add type annotations to wrap_func to preserve function signature using ParamSpec and TypeVar
- Add return type annotation to register_callback
- Remove redundant cast() call that was obscuring type information
- Remove unused cast import

These changes ensure that mypy can properly understand that the callback decorator
preserves the original function's signature and return type in strict mode.
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
16 New Blocker Issues (required ≤ 5)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@robertclaus

Copy link
Copy Markdown
Contributor

@rakrsh thank you for looking into this! Adding an uploader component directly to Dash is an interesting idea. We took a quick look at the implementation in this PR and have some suggestions.

  1. The dash-uploader code this is porting over hasn't been maintained in a while; so we would want to re-implement the functionality if we're introducing it as a new core component.
  2. We're on the fence about whether a component this complex should be part of the Dash core repo vs a standalone package. I think we could be convinced either way, but a standalone package benefits from being easier to maintain.
  3. There are some considerations for how this would integrate with Plotly's app hosting services on Plotly Cloud and Dash Enterprise; so if we do want to add it to the core libraries it might be easier for Plotly to develop given that additional context.

Since the PR has been sitting for a few weeks, we're also going to close it for now. Your branch should still be available, so feel free to re-open if you continue to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants