Fix: Table question's columns panel forces the whole page to scroll w… - #52
Open
UncleTomsCabi wants to merge 3 commits into
Open
Fix: Table question's columns panel forces the whole page to scroll w…#52UncleTomsCabi wants to merge 3 commits into
UncleTomsCabi wants to merge 3 commits into
Conversation
…ith many columns ## Problem When a `Table` question has enough columns to overflow the viewport (reproduced with 7 columns), reaching the last ones requires scrolling the whole page instead of just the columns panel. Because the panel is a Bootstrap dropdown menu, scrolling the page while it stays open can make it jump back to the top instead of staying anchored to its toggle button, making it effectively impossible to configure columns past a certain point. ## Fix Give the columns container its own scroll (`max-height: 60vh; overflow-y: auto`) instead of letting it grow past the viewport. The "Add column" button stays outside the scrollable area and is always visible. ## Testing Added a regression test (`TableQuestionAdminConfigRenderingTest`) asserting that the rendered admin template's columns container carries both `overflow-y: auto` and a `max-height` constraint — a bare `overflow-y: auto` with no height limit never actually scrolls, so both are checked together.
Rom1-B
self-requested a review
August 24, 2026 12:26
Rom1-B
reviewed
Aug 24, 2026
stonebuzz
approved these changes
Aug 26, 2026
stonebuzz
left a comment
stonebuzz
left a comment
Contributor
There was a problem hiding this comment.
LGTM (With review requested)
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith many columns
Problem
When a
Tablequestion has enough columns to overflow the viewport (reproduced with 7 columns), reaching the last ones requires scrolling the whole page instead of just the columns panel. Because the panel is a Bootstrap dropdown menu, scrolling the page while it stays open can make it jump back to the top instead of staying anchored to its toggle button, making it effectively impossible to configure columns past a certain point.Fix
Give the columns container its own scroll (
max-height: 60vh; overflow-y: auto) instead of letting it grow past the viewport. The "Add column" button stays outside the scrollable area and is always visible.Testing
Added a regression test (
TableQuestionAdminConfigRenderingTest) asserting that the rendered admin template's columns container carries bothoverflow-y: autoand amax-heightconstraint — a bareoverflow-y: autowith no height limit never actually scrolls, so both are checked together.