Skip to content

Tighten review prompt to suppress style nits#39

Merged
benlangfeld merged 1 commit intomainfrom
review-prompt-adjustments
Apr 29, 2026
Merged

Tighten review prompt to suppress style nits#39
benlangfeld merged 1 commit intomainfrom
review-prompt-adjustments

Conversation

@jonwmarshall
Copy link
Copy Markdown
Contributor

Summary

  • A recent agentic review left a low-severity comment that was both incorrect (the indentation it flagged is what rubocop autoformatting enforces) and explicitly the kind of style/convention nit the prompt told it to avoid.
  • Tightens prompts/review.md: style/formatting/convention comments become a hard prohibition (with reasoning that the reviewer hasn't read the linter config), low is redefined as a minor real bug rather than a place for observations, and every comment at every severity now requires a named failure mode.
  • Adds a phrase-level filter ("not a bug," "just noting," "unconventional," "works, but"...) — the comment that prompted this would have tripped it.

Test plan

  • Run the agentic reviewer against a PR with style-only deltas; confirm no inline comments are emitted.
  • Run against a PR with a real low-severity bug; confirm low findings still surface with a stated failure mode.

🤖 Generated with Claude Code

Style/formatting/convention comments are now a hard prohibition rather
than "avoid," with reasoning that the reviewer hasn't read the repo's
linter/formatter config. Adds a phrase-level filter ("not a bug," "just
noting," "unconventional," etc.), redefines `low` as a minor real bug
rather than a place for observations, and extends the failure-mode
requirement to all severities.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@jonwmarshall jonwmarshall requested a review from a team as a code owner April 28, 2026 13:25
@benlangfeld benlangfeld merged commit 2252a28 into main Apr 29, 2026
4 checks passed
@benlangfeld benlangfeld deleted the review-prompt-adjustments branch April 29, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants