Remove --slice-formula from all Makefiles and set in Makefile.common#1049
Merged
Conversation
Also, use SMT-only Z3 tactic for proof of poly_invntt_tomont_c() which is faster with --slice-formula Signed-off-by: Rod Chapman <rodchap@amazon.com>
Contributor
Author
|
Proof times on Grv4/Ubuntu, CPU user time in minutes:seconds for param sets 44,65,87: |
Contributor
CBMC Results (ML-DSA-44)
Full Results (185 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (185 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (185 proofs)
|
mkannwischer
approved these changes
Apr 20, 2026
Contributor
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @rod-chapman. LGTM. Performance improved slightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove --slice-formula from all Makefiles and set in Makefile.common
Also, use SMT-only Z3 tactic for proof of poly_invntt_tomont_c() which is faster with --slice-formula