feat: support php-parser 3.4.0 (pipe operator and readonly anonymous classes)#2459
Open
jorgsowa wants to merge 5 commits intoprettier:mainfrom
Open
feat: support php-parser 3.4.0 (pipe operator and readonly anonymous classes)#2459jorgsowa wants to merge 5 commits intoprettier:mainfrom
jorgsowa wants to merge 5 commits intoprettier:mainfrom
Conversation
Collaborator
|
This is probably still missing the dependency bump |
Collaborator
Author
|
Yes, missed that. Done in |
Collaborator
|
👍 now you might still have to set the PHP version in |
czosel
reviewed
Mar 23, 2026
Comment on lines
+33
to
+35
| $result = | ||
| "Hello, World!" |> | ||
| (strtoupper(...) |> (trim(...) |> htmlspecialchars(...))); |
Collaborator
There was a problem hiding this comment.
Hmm, I think this still needs a few changes:
- unnecessary brackets
- pipe operator should be at beginning of each line if multi-line
- only one pipe per line
The PHP docs show an example where the trailing semicolon is on its own line, we might also want to implement that?
Suggested change
| $result = | |
| "Hello, World!" |> | |
| (strtoupper(...) |> (trim(...) |> htmlspecialchars(...))); | |
| $result = "Hello, World!" | |
| |> strtoupper(...) | |
| |> trim(...) | |
| |> htmlspecialchars(...) | |
| ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports php-parser 3.4.0
Changes: