Skip to content

Switch json5 to @bybrave/json5 - #118

Draft
fisker wants to merge 1 commit into
mainfrom
esm-json5
Draft

Switch json5 to @bybrave/json5#118
fisker wants to merge 1 commit into
mainfrom
esm-json5

Conversation

@fisker

@fisker fisker commented Aug 13, 2026

Copy link
Copy Markdown
Member

Switch to ESM fork for better tree-shaking json5/json5#348 (comment)

Doing the same in core prettier/prettier#19843

@pkg-pr-new

pkg-pr-new Bot commented Aug 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/cli@118.tgz

commit: 7e28000

@43081j

43081j commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

@fisker given it has no downloads pretty much, i'd be cautious merging this one yet 👀

does it fix anything? if its just for sake of having an ESM dependency, maybe we can wait a bit for it to gain some usage

@fisker

fisker commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

does it fix anything?

No.

maybe we can wait a bit for it to gain some usage

Sure.

@fisker
fisker marked this pull request as draft August 13, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants