Skip to content

feat(webgl): add texCoord parameter to getFinalColor hook#8706

Open
YuktiNandwana wants to merge 2 commits intoprocessing:dev-2.0from
YuktiNandwana:feature/finalColor-texCoord-2.0
Open

feat(webgl): add texCoord parameter to getFinalColor hook#8706
YuktiNandwana wants to merge 2 commits intoprocessing:dev-2.0from
YuktiNandwana:feature/finalColor-texCoord-2.0

Conversation

@YuktiNandwana
Copy link
Copy Markdown

Resolves #8667

Changes Made

  • Updated basic.frag, normal.frag, phong.frag, line.frag to pass texCoord to HOOK_getFinalColor()
  • Updated p5.RendererGL.js (4 places) with new hook signature
  • Updated WebGPU shaders: color.js, material.js, line.js
  • Updated p5.RendererWebGPU.js (3 places) with new hook signature
  • Updated JSDoc in p5.Shader.js
  • Added visual test (WIP - need help with correct p5.strands syntax for texCoord)

Testing

  • All existing tests pass
  • 1 pre-existing failure unrelated to this PR
  • Visual test added but needs review on correct strands syntax

cc @davepagurek - Could you help verify the correct way to access texCoord in the visual test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant