feat(mixin): add "All" option to cluster variable in dashboards #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the cluster variable to support an "All" option in Grafana dashboards, allowing users to view metrics across all clusters or in environments where the cluster label may be missing. Changes: - Add includeAll with allValue=".*" to cluster variable definitions - Change all PromQL queries from exact matching (cluster="$cluster") to regex matching (cluster=~"$cluster") Affected dashboards: - Node Exporter / Nodes (Linux, Darwin, AIX) - USE Method / Node - USE Method / Cluster Signed-off-by: Willian Paixao <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR enables the cluster variable in Grafana dashboards to support an "All" option, allowing users to view metrics across all clusters simultaneously or handle cases where the cluster label may be missing.
Key changes:
- Added
includeAllwithallValue=".*"to cluster variable definitions in both affected files - Converted all PromQL queries from exact cluster matching (
cluster="$cluster") to regex matching (cluster=~"$cluster")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/node-mixin/lib/prom-mixin.libsonnet | Updated cluster variable definition and converted 46 PromQL queries to use regex matching for the Node Exporter dashboard across Linux, Darwin, and AIX platforms |
| docs/node-mixin/dashboards/use.libsonnet | Updated cluster variable definition and converted 42 PromQL queries to use regex matching for USE Method dashboards (Node and Cluster views) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Author
|
Hey @discordianfish @bwplotka @SuperQ could I get a review here please? 🎅🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the cluster variable to support an "All" option in Grafana dashboards, allowing users to view metrics across all clusters or in environments where the cluster label may be missing.
Changes:
Affected dashboards: