Open
Conversation
waldemarKunkel
suggested changes
Oct 13, 2025
Comment on lines
391
to
401
| @property | ||
| def children(self) -> List['Element']: | ||
|
|
||
| """Returns a list of child elements.""" | ||
| return [Element(element=child, url=self.url, default_encoding=self.default_encoding) | ||
| for child in self.element.getchildren()] | ||
|
|
||
| def getchildren(self) -> List['Element']: | ||
| """Returns a list of child elements (lxml compatibility method).""" | ||
| return self.children | ||
| def attrs(self) -> _Attrs: |
There was a problem hiding this comment.
Hi @karan96108, just found this PR by chance. Would suggest this change:
Suggested change
| @property | |
| def children(self) -> List['Element']: | |
| """Returns a list of child elements.""" | |
| return [Element(element=child, url=self.url, default_encoding=self.default_encoding) | |
| for child in self.element.getchildren()] | |
| def getchildren(self) -> List['Element']: | |
| """Returns a list of child elements (lxml compatibility method).""" | |
| return self.children | |
| def attrs(self) -> _Attrs: | |
| @property | |
| def children(self) -> List['Element']: | |
| """Returns a list of child elements.""" | |
| return [Element(element=child, url=self.url, default_encoding=self.default_encoding) | |
| for child in self.element.getchildren()] | |
| def getchildren(self) -> List['Element']: | |
| """Returns a list of child elements (lxml compatibility method).""" | |
| return self.children | |
| @property | |
| def attrs(self) -> _Attrs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add child node traversal methods to Element class
Problem
Currently users need to switch between requests-html and lxml.etree to work with child nodes,
creating unnecessary complexity.
Implementation
Added two methods to Element class:
childrenproperty - Returns list of direct child elementsgetchildren()method - Provides lxml.etree compatibilityBreaking Changes
None. Adds new functionality while maintaining backwards compatibility.
Usage