Skip to content

Add optional compact parameter for party embed display#116

Open
Claude wants to merge 7 commits intomainfrom
claude/make-embed-inline-field-optional
Open

Add optional compact parameter for party embed display#116
Claude wants to merge 7 commits intomainfrom
claude/make-embed-inline-field-optional

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Mar 12, 2026

Party embeds now support configurable inline field display via an optional compact boolean parameter. By default, parties use non-compact mode (stacked fields) for better readability.

Changes

  • Removed global constant: Eliminated EMBED_FIELD_INLINE in favor of per-party configuration
  • Added compact field: Party data structure now includes compact: bool (default: False)
  • Updated embed rendering: create_party_embed() reads party.get("compact", False) to control inline display
  • Extended command interface: party create accepts optional compact parameter
    # Non-compact (default)
    [p]party create "Raid Night" "Tank Healer DPS"
    
    # Compact mode
    [p]party create "Raid Night" "Tank Healer DPS" True
  • Preserved backward compatibility: Existing parties without the field default to non-compact mode

All party creation paths (command, modal, template) properly initialize the compact field.

- Removed global EMBED_FIELD_INLINE constant
- Added 'compact' boolean field to party data structure (default: False)
- Updated create_party_embed to use party['compact'] for inline field setting
- Added optional compact parameter to party_create command
- Updated CreatePartyModal, party_template_use, and party_list to use compact setting
- Default behavior is NOT compact (inline=False) for better readability

Co-authored-by: psykzz <1134201+psykzz@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Add optional embed inline field parameter for party cog Add optional compact parameter for party embed display Mar 12, 2026
@Claude Claude AI requested a review from psykzz March 12, 2026 17:45
@psykzz
Copy link
Copy Markdown
Owner

psykzz commented Apr 19, 2026

@claude[agent] make it possible to edit existing (pre-change) parties to also make them compact or not.

- Added new `party compact` command to toggle compact mode for existing parties
- Works for both newly created parties and pre-existing parties
- Follows same permission pattern as other party edit commands (owner or admin)
- Updates party message immediately and logs changes to modlog
- Supports both True (compact/inline) and False (stacked) display modes

Agent-Logs-Url: https://github.com/psykzz/cogs/sessions/0eca8b3f-be15-4623-a8d3-82b3d8ecc63e

Co-authored-by: psykzz <1134201+psykzz@users.noreply.github.com>
@Claude
Copy link
Copy Markdown
Contributor Author

Claude AI commented Apr 19, 2026

@claude[agent] make it possible to edit existing (pre-change) parties to also make them compact or not.

Added party compact command to toggle compact mode for existing parties. Works for both new and pre-existing parties (defaults to False for backward compatibility).

Usage:

  • [p]party compact <party_id> True - Enable compact (inline) mode
  • [p]party compact <party_id> False - Enable stacked mode (default)

The command follows the same permission model as other party edit commands (owner or admin only) and immediately updates the party embed. (80ab4cf)

@psykzz psykzz marked this pull request as ready for review April 19, 2026 17:26
@psykzz
Copy link
Copy Markdown
Owner

psykzz commented Apr 20, 2026

@copilot is this also support in the edit modal?

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

@copilot is this also support in the edit modal?

It wasn't — both modals were already at Discord's 5-field limit. Added compact support by merging allow_multiple and compact into a single "Settings" field (one setting per line, e.g. allow_multiple=yes / compact=no). The edit modal pre-populates the current party values so they're easy to change. (20087bb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants