feat: meld native toolchain + synth attr cleanup#444
Merged
Conversation
Wires meld_fuse to resolve the meld CLI via a proper Bazel toolchain instead of an unbound private attribute. Adds `meld_toolchain_type`, a `meld_repository` rule that downloads the native binary from the JSON registry, and a module extension to expose it. Platforms without a published meld binary (Windows today) get a stub toolchain gated by @platforms//:incompatible so module resolution succeeds but meld_fuse targets are correctly filtered out. synth_compile's `_synth` private attribute is promoted to a public mandatory `synth` attribute since synth has no published releases — users must point at a locally built binary, which is now an honest part of the rule API. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meld_fuseto resolve the meld CLI via a real Bazel toolchain (meld_toolchain_type) instead of an unbound private_meldattribute, which was previously unusable.meld_repositorythat downloads the native meld binary from the JSON registry viatool_registry, plus a module extension in//wasm:extensions.bzl.@platforms//:incompatible— module resolution succeeds andmeld_fusetargets are cleanly filtered out.synth_compile's_synthprivate attribute to a public mandatorysynthattribute, reflecting that synth has no published releases and users must supply a locally built binary.Context
This is the first follow-up to #442: the pipeline rules landed there but
meld_fusehad no toolchain path, so the rule couldn't actually be invoked. This PR makes it executable end-to-end on supported platforms (linux_{amd64,arm64}, darwin_{amd64,arm64}).Test plan
bazel build //wasm:defs //toolchains:meld_toolchain_type— loads cleanlybazel fetch @meld_toolchain//...— downloads native binary via registrymeld --helpfrom downloaded binary — confirms executablebazel build --nobuild //wasm/... //toolchains/... //providers/...— 54 targets analyzebazel build --nobuild //examples/basic/... //examples/wizer_example/... //examples/aot_example/... //examples/wasm_signing/... //examples/wac_oci_composition/...— 125 targets analyze, no regressions🤖 Generated with Claude Code