Skip to content

Transform distributions#925

Open
NicolaCourtier wants to merge 13 commits intodevelopfrom
transform-distributions
Open

Transform distributions#925
NicolaCourtier wants to merge 13 commits intodevelopfrom
transform-distributions

Conversation

@NicolaCourtier
Copy link
Copy Markdown
Member

Description

The implementation of parameters, distributions and transformations is over-complicated. The aim here is to simplify the definitions and interactions between these classes to improve maintainability. A new UnboundedDistribution is created to define the behaviour of a parameter without a statistical distribution. The get_transformed_distribution functionality is added to both univariate and multivariate distributions.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 89.33333% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.34%. Comparing base (4628a65) to head (de03cdf).
⚠️ Report is 49 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/parameters/distributions.py 87.69% 16 Missing ⚠️
pybop/parameters/multivariate_distributions.py 85.36% 12 Missing ⚠️
pybop/parameters/parameter.py 94.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #925      +/-   ##
===========================================
+ Coverage    89.41%   92.34%   +2.92%     
===========================================
  Files           63       73      +10     
  Lines         4857     5670     +813     
===========================================
+ Hits          4343     5236     +893     
+ Misses         514      434      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NicolaCourtier NicolaCourtier changed the base branch from add-noise-util to develop April 2, 2026 16:08
@NicolaCourtier NicolaCourtier marked this pull request as ready for review April 10, 2026 13:50
@NicolaCourtier NicolaCourtier requested a review from SarahRo April 10, 2026 13:50
@NicolaCourtier NicolaCourtier linked an issue Apr 10, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align the setting and passing of bounds

1 participant