Skip to content

Remove a type: ignore - Type gethookproxy/ihook as HookRelay | FSHookProxy#14728

Open
adamtheturtle wants to merge 2 commits into
pytest-dev:mainfrom
adamtheturtle:adamtheturtle/type-gethookproxy-fshookproxy
Open

Remove a type: ignore - Type gethookproxy/ihook as HookRelay | FSHookProxy#14728
adamtheturtle wants to merge 2 commits into
pytest-dev:mainfrom
adamtheturtle:adamtheturtle/type-gethookproxy-fshookproxy

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Jul 19, 2026

Copy link
Copy Markdown

No description provided.

gethookproxy already returns FSHookProxy when some conftests are stripped;
annotate that honestly and drop the assignment type ignore.

Co-authored-by: Cursor <cursoragent@cursor.com>
@adamtheturtle adamtheturtle changed the title Type gethookproxy/ihook as HookRelay | FSHookProxy Remove a type: ignore - Type gethookproxy/ihook as HookRelay | FSHookProxy Jul 19, 2026
Ignore undocumented FSHookProxy in Sphinx nitpicks, and add a misc changelog entry.

Co-authored-by: Cursor <cursoragent@cursor.com>
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jul 19, 2026
@The-Compiler

Copy link
Copy Markdown
Member

I don't think this makes sense. FSHookProxy has a __getattr__ to be a transparent proxy over PytestPluginManager, so it makes sense from a typing perspective to pretend this is a PluginManager object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants