fix: keep pytest_terminal_summary under --no-summary#14730
Open
l46983284-cpu wants to merge 1 commit into
Open
fix: keep pytest_terminal_summary under --no-summary#14730l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
--no-summary was skipping the entire pytest_terminal_summary hook, which silenced third-party plugins (e.g. coverage) as well as pytest's own FAILURES/ERRORS sections. Still suppress TerminalReporter's built-in summary body, but always call the hook so plugins can report. Closes pytest-dev#14724 Signed-off-by: Alex Chen <l46983284@gmail.com>
psf-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-summarycurrently skips calling thepytest_terminal_summaryhook entirely, which silences third-party plugins (e.g. pytest-cov) as well as pytest's own FAILURES/ERRORS sections.This change always invokes the hook, but gates TerminalReporter's built-in summary sections on
not no_summary, so:--no-summaryCloses #14724
Test plan
TestTerminalFunctional::test_no_summary(FAILURES still suppressed)test_no_summary_still_runs_terminal_summary_hook