Collect sibling tests when parent and subfolder are both given - #14878
Closed
arronKler wants to merge 2 commits into
Closed
Collect sibling tests when parent and subfolder are both given#14878arronKler wants to merge 2 commits into
arronKler wants to merge 2 commits into
Conversation
Specifying both a parent directory and one of its subfolders must collect sibling folders too, not only the named child. Cover the pytest-dev#13319 layout (tests only under subfolders) and unit-test that normalization keeps the parent path. Fixes pytest-dev#13319
psf-chronographer
Bot
added
the
bot:chronographer:provided
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing both a parent directory and one of its subfolders collected only the named subfolder:
expected every test under
parent/, but onlyparent/sub1ran.Collection arguments are already normalized so a parent path replaces an overlapping child (
normalize_collection_arguments, added for #12083 / #13704). This keeps that behavior covered for the layout in #13319: tests only in sibling subfolders, none in the parent directory itself, including a trailing slash on the parent.Fixes #13319