Raise ValueError for non-option names in addoption() - #14880
Open
arronKler wants to merge 1 commit into
Open
Conversation
parser.addoption("shuffle") was accepted as a positional argument
and later failed with a confusing required-argument or dest-conflict
error. Reject names that do not start with '-' or '--'.
Fixes pytest-dev#13817
psf-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parser.addoption("shuffle")(missing--) is treated by argparse as a required positional argument. The original report was a secondaryAttributeErrorwhile formatting that failure; after the argparse rewrite the same call still fails later with a dest-conflict or "arguments are required" error.Reject names that do not start with
-or--at registration time, and suggest the--nameform when the missing prefix is the likely typo.Fixes #13817