Repository navigation
Fix monkeypatch resolution of cached submodules - #15157
Open
SharifWaqas wants to merge 2 commits into
Open
SharifWaqas wants to merge 2 commits into
SharifWaqas wants to merge 2 commits into
Conversation
Use the module returned by importlib when a parent package no longer exposes a cached submodule. Cover setattr, delattr, and undo behavior. Developed with OpenAI Codex assistance.
|
Verified the fix locally. The new regression tests in testing/test_monkeypatch.py pass on this branch (46 passed, 2 skipped in testing/test_monkeypatch.py), and I reproduced the failure on main: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix string-based monkeypatch.setattr and delattr for cached submodules whose parent-package attribute is missing. Use the module returned by importlib. Regression tests cover both operations and undo.
Validation: 4,688 tests passed with no failures. Both regressions fail before the fix. Pre-commit checks passed.
Developed with OpenAI Codex assistance. The temporary changelog/0.bugfix.rst will be renamed to this PR number.