Conversation
There seems to be no servers allowing search by uid (basically a text search) without allowing other text searches and vice versa - so the search.text.by-uid "feature" is moot, and has been removed in this commit. get_object_by_uid() already has a client-side fallback via _hacks="insist" that fetches all objects and filters client-side when the server returns no results from text search. The search.text.by-uid guard in the tests was therefore no longer needed, and all skip_unless_support/is_supported checks in tests have been removed. Some tests now failed for other reasons, so the tests have been made a bit more robust. Closes #586 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The cyrusimap/cyrus-docker-test-server image was rebuilt on 2026-04-03 with a multi-stage slim build that broke CalDAV startup: the httpd module never comes up on port 8080, causing the health check to fail before CI can even run. Pin to the digest that was current on 2026-03-30 (confirmed passing in GitHub Actions run 23748898521) until the upstream image is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blurb below was produced by Claude. I'll fix a better description on the git commit and force-push.
get_object_by_uid()already has a client-side fallback via_hacks="insist"that fetches all objects and filters client-side when the server returns no
results from text search. The
search.text.by-uidguard was therefore nolonger needed, and all skip_unless_support/is_supported checks in tests
have been removed.
Closes #586
Co-Authored-By: Claude Sonnet 4.6 [email protected]