Skip to content

Fix off-by-one error in MAXIMUM_REMINDERS check #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliveman-au wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −5
Open

Fix off-by-one error in MAXIMUM_REMINDERS check #3497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7848ebb
Fix AttributeError when reminder jump_url is None
oliveman-au Apr 24, 2026
0e6bc79
Fix off-by-one error in MAXIMUM_REMINDERS check
oliveman-au Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions bot/exts/utils/reminders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,15 @@ async def send_reminder(self, reminder: dict, expected_time: time.Timestamp | No
mentionable.mention async for mentionable in self.get_mentionables(reminder["mentions"])
])

jump_url = reminder.get("jump_url")
embed.description += f"\n[Jump back to when you created the reminder]({jump_url})"
partial_message = channel.get_partial_message(int(jump_url.split("/")[-1]))
jump_url = reminder.get("jump_url") or ""
if jump_url:
embed.description += f"\n[Jump back to when you created the reminder]({jump_url})"
partial_message = channel.get_partial_message(int(jump_url.split("/")[-1])) if jump_url else None
try:
await partial_message.reply(content=f"{additional_mentions}", embed=embed)
if partial_message:
await partial_message.reply(content=f"{additional_mentions}", embed=embed)
else:
await channel.send(content=f"<@{reminder['author']}> {additional_mentions}", embed=embed)
except discord.HTTPException as e:
log.info(
f"There was an error when trying to reply to a reminder invocation message, {e}, "
Expand Down Expand Up @@ -475,7 +479,7 @@ async def new_reminder(

# Let's limit this, so we don't get 10 000
# reminders from kip or something like that :P
if len(active_reminders) > MAXIMUM_REMINDERS:
if len(active_reminders) >= MAXIMUM_REMINDERS:
await send_denial(ctx, "You have too many active reminders!")
return

Expand Down