Fix silent placeholder when editing reminder content with empty reply#3501
Open
oliveman-au wants to merge 3 commits intopython-discord:mainfrom
Open
Fix silent placeholder when editing reminder content with empty reply#3501oliveman-au wants to merge 3 commits intopython-discord:mainfrom
oliveman-au wants to merge 3 commits intopython-discord:mainfrom
Conversation
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When running
!remind edit content <id>while replying to a message with no text content (e.g. an image-only message), the bot silently sets the reminder content to*See referenced message.*and confirms "That reminder has been edited successfully!" — giving the user no indication their content was replaced with a useless placeholder.When the reminder fires, the user just gets pinged with
*See referenced message.*and has no idea what they were supposed to remember.Fixed by returning
Nonefromtry_get_content_from_replywhen the referenced message has no content, sending an error message to the user, and returning early fromedit_reminder_contentso the edit never goes through.