Reject past expiration dates when editing reminder duration#3502
Open
oliveman-au wants to merge 1 commit intopython-discord:mainfrom
Open
Reject past expiration dates when editing reminder duration#3502oliveman-au wants to merge 1 commit intopython-discord:mainfrom
oliveman-au wants to merge 1 commit intopython-discord:mainfrom
Conversation
Author
|
reproduced - edited a reminder to expire in 1 second, bot confirmed the edit with a date in the past then immediately fired the reminder. no validation that the new expiration is in the future. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!remind edit durationaccepts past dates with no validation. The bot confirms "That reminder has been edited successfully!" and then immediately fires the reminder since the expiration is already in the past.Added a check to reject the edit if the provided expiration is before the current time, matching the expected behaviour of the original
!remind newcommand.