Implement an OIDC-based backend for uc-cdis/fence#341
Draft
VJalili wants to merge 1 commit intopython-social-auth:masterfrom
Draft
Implement an OIDC-based backend for uc-cdis/fence#341VJalili wants to merge 1 commit intopython-social-auth:masterfrom
VJalili wants to merge 1 commit intopython-social-auth:masterfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fence repo: https://github.com/uc-cdis/fence
TODOs:
Fence does not support
nonce(see Includenonceclaim in the ID token uc-cdis/fence#600 )---a required claim by psa (and oidc specifications)---that results inAuthTokenErrorexception:social-core/social_core/backends/open_id_connect.py
Lines 134 to 143 in 000f8e5
Hence, either psa should make
nonceoptional (Allow nonce to be optional in OIDC Authorization workflow #315) or Fence implement it. IMHO, based on OIDC-specs (see the following quote), the latter is preferred.