Skip to content

Don't allow None as happy_eyeballs_delay. - #3589

Merged
A5rocks merged 3 commits into
python-trio:mainfrom
A5rocks:no-none-happy-eyeballs
Nov 13, 2026
Merged

A5rocks merged 3 commits into
python-trio:mainfrom
A5rocks:no-none-happy-eyeballs

Conversation

@A5rocks

@A5rocks A5rocks commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #3588

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (93e6b2e) to head (5c935ff).

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3589   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19555        19553    -2     
  Branches         1330         1329    -1     
===============================================
- Hits            19555        19553    -2     
Files with missing lines Coverage Δ
src/trio/_highlevel_open_tcp_stream.py 100.00000% <100.00000%> (ø)
src/trio/_highlevel_ssl_helpers.py 100.00000% <ø> (ø)
src/trio/_tests/test_highlevel_open_tcp_stream.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks
A5rocks force-pushed the no-none-happy-eyeballs branch from 69a0d74 to 5cacc8a Compare November 11, 2026 23:51
@A5rocks
A5rocks force-pushed the no-none-happy-eyeballs branch from 5cacc8a to 5c935ff Compare November 12, 2026 00:36
@A5rocks
A5rocks merged commit 6da4d42 into python-trio:main Nov 13, 2026
54 checks passed
@A5rocks
A5rocks deleted the no-none-happy-eyeballs branch November 13, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We should stop allowing None for happy_eyeballs_delay

2 participants