Add documentation for Control class (issue #2150)#2207
Open
mosessamofficial-sys wants to merge 5 commits intopython-visualization:mainfrom
Open
Add documentation for Control class (issue #2150)#2207mosessamofficial-sys wants to merge 5 commits intopython-visualization:mainfrom
mosessamofficial-sys wants to merge 5 commits intopython-visualization:mainfrom
Conversation
Contributor
Author
|
Hi, this is my first contribution. |
Collaborator
|
Looks good to me. There were some formatting issues, which I can fix if you want. If you want to contribute more frequently, you may want to setup our commit hooks framework. This will automate a lot of the basic checks. |
Collaborator
|
There is a small issue. You used a Dummy example |
Contributor
Author
|
Thanks for the review! I’ll update the example to use a real-world Leaflet control so the automated tests pass. |
Contributor
Author
|
why its always failing , i don't understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for the Control class, including examples of built-in controls and wiring custom Leaflet plugin controls.
Closes #2150