Skip to content

Add documentation for Control class (issue #2150)#2207

Open
mosessamofficial-sys wants to merge 5 commits intopython-visualization:mainfrom
mosessamofficial-sys:main
Open

Add documentation for Control class (issue #2150)#2207
mosessamofficial-sys wants to merge 5 commits intopython-visualization:mainfrom
mosessamofficial-sys:main

Conversation

@mosessamofficial-sys
Copy link
Contributor

Adds documentation for the Control class, including examples of built-in controls and wiring custom Leaflet plugin controls.

Closes #2150

@mosessamofficial-sys
Copy link
Contributor Author

Hi, this is my first contribution.
Please let me know if any changes are required.

@hansthen
Copy link
Collaborator

hansthen commented Feb 25, 2026

Looks good to me. There were some formatting issues, which I can fix if you want. If you want to contribute more frequently, you may want to setup our commit hooks framework. This will automate a lot of the basic checks.

@hansthen
Copy link
Collaborator

There is a small issue. You used a Dummy example L.Control.MyPlugin. Because of that our automated tests fail. Can you rewrite the issue using a simple real world example?

@mosessamofficial-sys
Copy link
Contributor Author

Thanks for the review! I’ll update the example to use a real-world Leaflet control so the automated tests pass.

@mosessamofficial-sys
Copy link
Contributor Author

why its always failing , i don't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation for the new Control class

2 participants