Repository navigation
skip-news and type-tests badges #421
Description
Activity
In my experience,
skip-newslabel should also be added totype-documentationPRs as generally docs PRs don't require a news fragment.Please see #363 for the previous discussion in this matter.
IMHO the opt-out model we currently have works well enough and makes the check more predictable. We could add custom rules for docs or tests, but they would have to be documented and there are cases where a NEWS entry is still required.
skip newsis now automatically applied to all PRs that only have adocslabel and don't already have a news item attached.We could also implement this for the
testslabel. Is this something we want to do? If so you can assign me and I'll prepare a PR.This might come in handy for python/cpython#94808
Closing, stale.
See also issue python/bedevere#669 and PR python/bedevere#670.
The short story
It would be nice if
skip-newslabel is automatically added when both conditions are true:type-testsbadgeNEWSentryExample: python/cpython#30472
Long version
I love working on unit-tests in CPython, but I have a small problem. When I submit a PR the CI is usually red, because
NEWScheck fails: there's noNEWSentry.Most of the reviewers say that test-only changes should not go to
NEWS(and I agree). But, right now the only way for non-members is to wait for someone who will putskip-newsbadge manually to turn the CI to be green. I don't think that precious time should be spent on that! 🙂Otherwise, it is less-likely to get a review (because PR has this red cross as its status, some people might think that something is broken).
For new contributors this might be even more problematic.