Skip to content

gh-143249: Fix buffer leak when overlapped operation fails to start (OS-Windows) #143250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyongtao-code wants to merge 8 commits into
base: main
Choose a base branch
from
+24 −3
Open

gh-143249: Fix buffer leak when overlapped operation fails to start (OS-Windows) #143250

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ebd149
Fix buffer leak when overlapped operation fails to start (OS-Windows)
hyongtao-code Dec 28, 2025
c523c11
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 28, 2025
2508cfb
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 28, 2025
b1a0ace
Revert "📜🤖 Added by blurb_it."
hyongtao-code Dec 28, 2025
2ac1a80
Add test case
hyongtao-code Dec 28, 2025
9b5c1c0
Construct a test case suitable for running with -R.
hyongtao-code Dec 28, 2025
9ae6017
Update NEW.s
hyongtao-code Dec 28, 2025
d69f8e5
Apply suggestion from @picnixz
hyongtao-code Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modules/overlapped.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ _overlapped_Overlapped_WSASendTo_impl(OverlappedObject *self, HANDLE handle,
case ERROR_IO_PENDING:
Py_RETURN_NONE;
default:
self->type = TYPE_NOT_STARTED;
Overlapped_clear(self);
return SetFromWindowsErr(err);
}
}
Expand Down Expand Up @@ -1873,7 +1873,7 @@ _overlapped_Overlapped_WSARecvFrom_impl(OverlappedObject *self,
case ERROR_IO_PENDING:
Py_RETURN_NONE;
default:
self->type = TYPE_NOT_STARTED;
Overlapped_clear(self);
return SetFromWindowsErr(err);
}
}
Expand Down Expand Up @@ -1940,7 +1940,7 @@ _overlapped_Overlapped_WSARecvFromInto_impl(OverlappedObject *self,
case ERROR_IO_PENDING:
Py_RETURN_NONE;
default:
self->type = TYPE_NOT_STARTED;
Overlapped_clear(self);
return SetFromWindowsErr(err);
}
}
Expand Down
Loading