gh-143237: Fix support of named pipes in the rotating logging handlers #143259
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andlers This fixes regression introduced in pythonGH-105887.
aisk
reviewed
Dec 29, 2025
Comment on lines
+6390
to
+6393
| try: | ||
| self.assertFalse(rh.shouldRollover(self.next_rec())) | ||
| finally: | ||
| rh.close() |
Contributor
There was a problem hiding this comment.
Hi, can we use self.addCleanup(rh.close) or
with contextlib.closing(rh):
self.assertFalse(rh.shouldRollover(self.next_rec()))
to simplify this test code?
Member
Author
There was a problem hiding this comment.
self.addCleanup(rh.close) will not work -- it should be closed before exiting the with block, otherwise the thread will hang.
I did not use contextlib.closing() only because contextlib is not yet imported. The difference is not so large. Maybe I'll do this at the end.
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit cc46702 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143259%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes regression introduced in GH-105887.