Skip to content

gh-152785: Upgrade LLVM to LLVM 22 in GitHub Action#152781

Open
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:llvm22
Open

gh-152785: Upgrade LLVM to LLVM 22 in GitHub Action#152781
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:llvm22

Conversation

@vstinner

@vstinner vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member

Upgrade LLVM to LLVM 22 in GitHub Action jobs:

  • Reusable Sanitizer
  • Reusable Ubuntu ("Install Clang and BOLT")
  • Tail calling interpreter

Keep LLVM 21 for the JIT compiler jobs.

Upgrade LLVM to LLVM 22 in GitHub Action jobs:

* Reusable Sanitizer
* Reusable Ubuntu ("Install Clang and BOLT")
* Tail calling interpreter

Keep LLVM 21 for the JIT compiler jobs.
@vstinner vstinner changed the title Upgrade LLVM to LLVM 22 in GitHub Action gh-152785: Upgrade LLVM to LLVM 22 in GitHub Action Jul 1, 2026
@vstinner vstinner marked this pull request as ready for review July 1, 2026 13:15
@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

All jobs completed successfully.

@corona10 @Fidget-Spinner: What do you think of upgrading to LLVM 22? Is there a reason to not use a newer LLVM version?

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BOLT, LGTM

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why not keep same version as JIT? In anycase I prefer unifying LLVM version as possible.

@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

But why not keep same version as JIT? In anycase I prefer unifying LLVM version as possible.

Tools/jit/_llvm.py looks for LLVM 21. If I understood correctly, it requires exactly this LLVM version. Correct me if I'm wrong.

@corona10

corona10 commented Jul 1, 2026

Copy link
Copy Markdown
Member

Tools/jit/_llvm.py looks for LLVM 21. If I understood correctly, it requires exactly this LLVM version. Correct me if I'm wrong.

I mean why we need to upgrade to LLVM22, just upgrade to 21

@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Well, usually a newer compiler is faster to build C code, produces faster programs, and provides better analysis of the code. So to me, it sounds interesting to use LLVM 22 instead of LLVM 21.

It would be nice if the JIT compiler would support LLVM 21 and LLVM 22, but it doesn't seem to be the case now.

For the JIT compiler, LLVM is only used to generate JIT stencils. For other CI jobs, LLVM is used to build the whole Python code base.

@vstinner

vstinner commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

@corona10: Are you ok with switching to LLVM 22? Or do you prefer to use LLVM 21 in all CI jobs? You approved the PR but then asked a question, so I'm now confused.

@corona10

corona10 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Prefer to keep it as 21 to match with JIT as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants