Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 9, 2025

For python/core-workflow#587.

This workflow is deprecated, and uses the pull_request_target target which can be insecure.

Let's test replacing it with the Read the Docs app. If it goes well, we can replace it in the other repos.

@python/organization-owners I've sent a request to install the RtD app for just this repo, please could you enable it?


📚 Documentation preview 📚: https://cpython-devguide--1713.org.readthedocs.build/

@JacobCoffee
Copy link
Member

@hugovk done

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk mentioned this pull request Dec 11, 2025
@hugovk
Copy link
Member Author

hugovk commented Dec 11, 2025

Thanks!

I opened #1714 to test, but it doesn't seem to have triggered.

At least I can see it's installed on this repo:

image

Will check tomorrow.

@hugovk
Copy link
Member Author

hugovk commented Dec 12, 2025

Right, figured it out on my fork: hugovk#37

@Mariatta Please could you add hugovk as a maintainer at https://app.readthedocs.org/dashboard/cpython-devguide/users/ ?

Then I can complete the migration to the app and then check "Show build overview in a comment" at https://app.readthedocs.org/dashboard/cpython-devguide/pull-requests/

@hugovk
Copy link
Member Author

hugovk commented Dec 17, 2025

@brettcannon Or please could you do the above to add me? #1713 (comment)

@brettcannon
Copy link
Member

@brettcannon Or please could you do the above to add me? #1713 (comment)

Invite sent!

@hugovk
Copy link
Member Author

hugovk commented Dec 18, 2025

Thanks, accepted!

I don't see the migration option for this repo, I think it needs someone with admin access to the repo as well. I've added @JacobCoffee to RtD and will talk with him to get it set up.

@JacobCoffee
Copy link
Member

JacobCoffee commented Dec 21, 2025

image

migrated everything, let me know if i can pick up any extra tasks

@AA-Turner
Copy link
Member

Thanks @JacobCoffee!

A

@AA-Turner

This comment was marked as outdated.

@AA-Turner

This comment was marked as outdated.

@hugovk
Copy link
Member Author

hugovk commented Dec 21, 2025

I've just checked "Show build overview in a comment" at https://app.readthedocs.org/dashboard/cpython-devguide/pull-requests/

image

And we now have a comment at #1714 (comment) 🚀

@hugovk hugovk closed this Dec 21, 2025
@hugovk hugovk reopened this Dec 21, 2025
@read-the-docs-community
Copy link

Documentation build overview

📚 CPython devguide | 🛠️ Build #30772675 | 📁 Comparing a4e3608 against latest (b24ed50)


🔍 Preview build

Show files changed (1 files in total): 📝 1 modified | ➕ 0 added | ➖ 0 deleted
File Status
developer-workflow/development-cycle/index.html 📝 modified

@AA-Turner AA-Turner merged commit 7e6a146 into python:main Dec 21, 2025
7 checks passed
@AA-Turner
Copy link
Member

AA-Turner commented Dec 21, 2025

Thanks all!

The comment is a little more verbose than before, but better to improve our security (& it does provide more info!).

A

@hugovk hugovk deleted the rm-documentation-links.yml branch December 21, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants