[yt-dlp] Rename private options type - #16354
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for contributing! |
|
The distinction I’m addressing is public typing API rather than runtime importability. The linked issue’s stored-dictionary pattern needs an explicit If Typeshed’s policy is to leave this type private despite #16331, I’m happy to close this, but the rename is the intended behavioral change: making the existing option schema a public type-checking API. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Rename the type-checking-only
_ParamsTypedDict to_YoutubeDLOptionsso its role is clear while preserving the private underscore required for a symbol that does not exist at runtime.Prepared with OpenAI Codex.