Skip to content

Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031)#19031

Open
ocvh wants to merge 1 commit intopytorch:mainfrom
ocvh:export-D100706182
Open

Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031)#19031
ocvh wants to merge 1 commit intopytorch:mainfrom
ocvh:export-D100706182

Conversation

@ocvh
Copy link
Copy Markdown
Contributor

@ocvh ocvh commented Apr 21, 2026

Summary:

Migrate the VGF backend's Vulkan dependencies from the custom third-party/vulkan-headers-1.4.343 package to the standardized third-party/khronos and third-party/volk packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (VK_ARM_tensors).

Changes:

  • targets.bzl: Replace custom vulkan-headers-1.4.343 deps with third-party/volk:volk_src, third-party/volk:volk-header, and third-party/khronos:vulkan-headers
  • VGFBackend.cpp, VGFSetup.h: Include <volk.h> directly instead of going through the vk_api.h shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)
  • third-party/volk/BUCK: Add volk_src export_file target for direct compilation into consumer targets

Differential Revision: D100706182

@ocvh ocvh requested a review from digantdesai as a code owner April 21, 2026 18:51
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Apr 21, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19031

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Unrelated Failures

As of commit 6a2e535 with merge base 1d37abd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 21, 2026

@ocvh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100706182.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Apr 21, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 21, 2026

Workflows were awaiting approval. CI has now been triggered for the ciflow labels on this PR.

@3l1 3l1 added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 21, 2026
@meta-codesync meta-codesync Bot changed the title Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031) Apr 21, 2026
ocvh pushed a commit to ocvh/executorch that referenced this pull request Apr 21, 2026
… khronos (pytorch#19031)

Summary:

Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`).

Changes:
- `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers`
- `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)
- `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets

Differential Revision: D100706182
@ocvh ocvh force-pushed the export-D100706182 branch from 5c4fceb to f609b85 Compare April 21, 2026 19:33
ocvh pushed a commit to ocvh/executorch that referenced this pull request Apr 21, 2026
… khronos (pytorch#19031)

Summary:

Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`).

Changes:
- `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers`
- `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)
- `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets

Differential Revision: D100706182
@ocvh ocvh force-pushed the export-D100706182 branch 2 times, most recently from 70957b5 to 984c2da Compare April 21, 2026 19:42
ocvh pushed a commit to ocvh/executorch that referenced this pull request Apr 21, 2026
… khronos (pytorch#19031)

Summary:
Pull Request resolved: pytorch#19031

Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`).

Changes:
- `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers`
- `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)
- `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets

Differential Revision: D100706182
… khronos (pytorch#19031)

Summary:
Pull Request resolved: pytorch#19031

Migrate the VGF backend's Vulkan dependencies from the custom `third-party/vulkan-headers-1.4.343` package to the standardized `third-party/khronos` and `third-party/volk` packages. The custom package had a regenerated volk with ARM tensor extensions, but the standard volk and khronos 1.4.341 headers already include these extensions (`VK_ARM_tensors`).

Changes:
- `targets.bzl`: Replace custom `vulkan-headers-1.4.343` deps with `third-party/volk:volk_src`, `third-party/volk:volk-header`, and `third-party/khronos:vulkan-headers`
- `VGFBackend.cpp`, `VGFSetup.h`: Include `<volk.h>` directly instead of going through the `vk_api.h` shim (which just forwarded to volk.h when USE_VULKAN_VOLK is defined)
- `third-party/volk/BUCK`: Add `volk_src` export_file target for direct compilation into consumer targets

Differential Revision: D100706182
@ocvh ocvh force-pushed the export-D100706182 branch from 984c2da to 6a2e535 Compare April 21, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants