Update .editorconfig file - #1913
Open
mhucka wants to merge 2 commits into
Open
Conversation
This updates the project `.editorconfig` file to use a better approach that was discovered over time in other projects. Instead of setting properties (particularly `indent_size`) explicitly for most file types, this sets global default values, and then only sets file-specific values if they need to differ from the default(s). In addition, this streamlines the comments to be more concise and focused.
mhucka
marked this pull request as ready for review
July 28, 2026 22:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes and updates the .editorconfig file, establishing a default indentation size of 4 spaces under [*] and adding specific rules for Makefiles, commit messages, and patch files. The review feedback highlights two important issues: first, setting a numeric indent_size for Makefiles can cause some editors to use spaces instead of tabs, leading to syntax errors; second, the global trim_trailing_whitespace = true setting will strip trailing double spaces in Markdown files, which are syntactically significant for line breaks. It is recommended to address both of these configuration issues.
mhucka
added
the
devops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the project
.editorconfigfile to use a better approach that was discovered over time in other projects. Instead of setting properties (particularlyindent_size) explicitly for most file types, this sets global default values, and then only sets file-specific values if they need to differ from the default(s).In addition, this streamlines the comments to be more concise and focused.